Skip to content

[Obs AI Assistant] Add settings to serverless allowlist#190098

Merged
neptunian merged 4 commits intoelastic:mainfrom
neptunian:190089-obs-ai-settings-allowlist-serverless
Aug 8, 2024
Merged

[Obs AI Assistant] Add settings to serverless allowlist#190098
neptunian merged 4 commits intoelastic:mainfrom
neptunian:190089-obs-ai-settings-allowlist-serverless

Conversation

@neptunian
Copy link
Contributor

@neptunian neptunian commented Aug 7, 2024 •
edited
Loading

Resolves #190089

  • Adds AI Assistant settings to allowlist in serverless. They will appear in both "Advanced Settings" and "AI Assistant for Observability" settings
  • Updates card text to fix title casing and have a more meaningful description
Screenshot 2024-08-07 at 3 40 22 PM

@obltmachine
Copy link

obltmachine commented Aug 7, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@neptunian
Copy link
Contributor Author

neptunian commented Aug 7, 2024

/ci

@neptunian
Copy link
Contributor Author

neptunian commented Aug 8, 2024

/ci

@neptunian neptunian marked this pull request as ready for review August 8, 2024 11:14
@neptunian neptunian requested review from a team as code owners August 8, 2024 11:14
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Aug 8, 2024
@kibana-ci
Copy link

kibana-ci commented Aug 8, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/management-settings-ids 137 141 +4

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
serverlessObservability 27.0KB 27.0KB +30.0B
Unknown metric groups

API count

id before after diff
@kbn/management-settings-ids 139 143 +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

eokoneyo
eokoneyo approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@eokoneyo eokoneyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only.

@neptunian neptunian merged commit 836af5f into elastic:main Aug 8, 2024
@kibanamachine kibanamachine added v8.16.0 backport:skip This PR does not require backporting labels Aug 8, 2024
@neptunian neptunian mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sabarasaba sabarasaba sabarasaba approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@eokoneyo eokoneyo eokoneyo approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting ci:project-deploy-observability Create an Observability project release_note:fix v8.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Obs AI Assistant] Cannot update settings in serverless

7 participants

@neptunian @obltmachine @kibana-ci @sabarasaba @shahzad31 @eokoneyo @kibanamachine